Skip to content

Allow newer packages when testing stable release versions in compat tests#64855

Closed
vatsrahul1001 wants to merge 2 commits into
mainfrom
fix/allow-newer-packages-stable-compat-test
Closed

Allow newer packages when testing stable release versions in compat tests#64855
vatsrahul1001 wants to merge 2 commits into
mainfrom
fix/allow-newer-packages-stable-compat-test

Conversation

@vatsrahul1001

@vatsrahul1001 vatsrahul1001 commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Fixes Compat tests failing for 3.2
Extends #64774 to also cover stable releases. The same exclude-newer = "4 days"
cooldown in pyproject.toml blocks compat tests from installing a newly released
stable version (e.g. apache-airflow==3.2.0) within the 4-day window. Safe to
override since both functions always install pinned specific versions.

  • Yes (please specify the tool below)
    Claude
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay for the function but am not 100% sure about security... if install fails with constraints it usually will retry w/o constraints and then would load all packages w/ cooldown.
I understand that now we have the problem of 5 days needed to get back-compat tests running but otherwise I am not sure if the generic opening is not opening the door too wide.

@potiuk WDYT?

@potiuk

potiuk commented Apr 7, 2026

Copy link
Copy Markdown
Member

Yes. Same thought . Let me try another atempt - also for the #64774

@vatsrahul1001 vatsrahul1001 requested a review from jscheffl April 7, 2026 18:19
@vatsrahul1001 vatsrahul1001 force-pushed the fix/allow-newer-packages-stable-compat-test branch from 44bc8a0 to 83f78dd Compare April 7, 2026 18:19
@vatsrahul1001

vatsrahul1001 commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Yes. Same thought . Let me try another atempt - also for the #64774

Maybe using this stable pin install

 if installation_spec.pre_release or (
        installation_spec.airflow_distribution and "==" in installation_spec.airflow_distribution

@jscheffl

jscheffl commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Yes. Same thought . Let me try another atempt - also for the #64774

Maybe using this

 if installation_spec.pre_release or (
        installation_spec.airflow_distribution and "==" in installation_spec.airflow_distribution

Yeah, this sounds like a good idea - if we exactly match we want to match exactly, irrespective of cooldown.

Still residual risk remains for failures where a retry attempts to install w/o constraints then. One option woul dbe to accept the risk and the other would be not to retry w/o constraints in such cases. Not fully sure though which is the least worse.

Comment thread scripts/in_container/install_airflow_and_providers.py Outdated
Comment thread scripts/in_container/install_airflow_and_providers.py
@potiuk

potiuk commented Apr 7, 2026

Copy link
Copy Markdown
Member

Yeah, this sounds like a good idea - if we exactly match we want to match exactly, irrespective of cooldown.

That won't work -> cooldown makes packages invisible - as if they not existed - so does not matter what spec you use.

@potiuk

potiuk commented Apr 7, 2026

Copy link
Copy Markdown
Member

I am testing different thing - exclusion of all airflow packages from cooldown

@vatsrahul1001

Copy link
Copy Markdown
Contributor Author

I am testing different thing - exclusion of all airflow packages from cooldown

Thanks @potiuk maybe after your PR on this we can rebase #64839 and merge

@potiuk

potiuk commented Apr 7, 2026

Copy link
Copy Markdown
Member

#64859 - better fix

@potiuk

potiuk commented Apr 7, 2026

Copy link
Copy Markdown
Member

I am testing different thing - exclusion of all airflow packages from cooldown

Thanks @potiuk maybe after your PR on this we can rebase #64839 and merge

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants