Fix K8s executor to use JoinableQueue matching its usage contract#63789
Merged
jscheffl merged 1 commit intoapache:mainfrom Mar 17, 2026
Merged
Fix K8s executor to use JoinableQueue matching its usage contract#63789jscheffl merged 1 commit intoapache:mainfrom
jscheffl merged 1 commit intoapache:mainfrom
Conversation
Dev-iL
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Dev-iL
force-pushed
the
2603/fix-k8s-joinable-queue
branch
from
54436de to
01ba310
Compare
The executor already treats both queues as joinable queues. It calls: - task_done() - join() - flush logic that assumes task accounting is tracked A plain manager Queue() does not match that contract. On Python 3.14 this showed up in teardown/error paths as: `ValueError: task_done() called too many times`
Dev-iL
force-pushed
the
2603/fix-k8s-joinable-queue
branch
from
01ba310 to
3f9c24a
Compare
jscheffl
approved these changes
Mar 17, 2026
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Mar 18, 2026
The executor already treats both queues as joinable queues. It calls: - task_done() - join() - flush logic that assumes task accounting is tracked A plain manager Queue() does not match that contract. On Python 3.14 this showed up in teardown/error paths as: `ValueError: task_done() called too many times`
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Mar 18, 2026
The executor already treats both queues as joinable queues. It calls: - task_done() - join() - flush logic that assumes task accounting is tracked A plain manager Queue() does not match that contract. On Python 3.14 this showed up in teardown/error paths as: `ValueError: task_done() called too many times`
fat-catTW
pushed a commit
to fat-catTW/airflow
that referenced
this pull request
Mar 22, 2026
The executor already treats both queues as joinable queues. It calls: - task_done() - join() - flush logic that assumes task accounting is tracked A plain manager Queue() does not match that contract. On Python 3.14 this showed up in teardown/error paths as: `ValueError: task_done() called too many times`
techcodie
pushed a commit
to techcodie/airflow
that referenced
this pull request
Mar 23, 2026
The executor already treats both queues as joinable queues. It calls: - task_done() - join() - flush logic that assumes task accounting is tracked A plain manager Queue() does not match that contract. On Python 3.14 this showed up in teardown/error paths as: `ValueError: task_done() called too many times`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self._manager.Queue()toself._manager.JoinableQueue()for bothtask_queueandresult_queuein the Kubernetes executor.Details
The Kubernetes executor calls
task_done(),join(), and uses flush logic that assumes task accounting is tracked — all of which require theJoinableQueuecontract. Using a plainQueue()doesn't support these operations. This mismatch was previously silent but manifests asValueError: task_done() called too many timesin teardown/error paths on Python 3.14 where queue behavior is stricter.related: #63520
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.6 following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.