Skip to content

Fix import errors not showing on UI#61163

Merged
ephraimbuddy merged 1 commit into
apache:mainfrom
astronomer:fix-import-error
Jan 29, 2026
Merged

Fix import errors not showing on UI#61163
ephraimbuddy merged 1 commit into
apache:mainfrom
astronomer:fix-import-error

Conversation

@vatsrahul1001

@vatsrahul1001 vatsrahul1001 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Import error stopped showing on UI after #60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Jan 28, 2026
vincbeck
vincbeck approved these changes Jan 28, 2026
View reviewed changes

@vincbeck vincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I would add unit test to cover that case though.

@vatsrahul1001

vatsrahul1001 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

looking at failing tests

@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.1.7 milestone Jan 29, 2026
ephraimbuddy
ephraimbuddy approved these changes Jan 29, 2026
View reviewed changes

@ephraimbuddy ephraimbuddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please confirm manually with different error scenarios

@ephraimbuddy ephraimbuddy merged commit 9facd66 into apache:main Jan 29, 2026
247 of 248 checks passed
@ephraimbuddy ephraimbuddy deleted the fix-import-error branch January 29, 2026 09:10
vatsrahul1001 added a commit to astronomer/airflow that referenced this pull request Jan 29, 2026
@vatsrahul1001
Fix import errors not showing on UI (apache#61163)
e3d8989 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
@vatsrahul1001 vatsrahul1001 mentioned this pull request Jan 29, 2026
Closed
vatsrahul1001 added a commit to astronomer/airflow that referenced this pull request Jan 29, 2026
@vatsrahul1001
Fix import errors not showing on UI (apache#61163)
79aa287 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
@vatsrahul1001 vatsrahul1001 mentioned this pull request Jan 29, 2026
Merged
This was referenced Jan 29, 2026
Closed
Closed
vatsrahul1001 added a commit to astronomer/airflow that referenced this pull request Jan 29, 2026
@vatsrahul1001
Fix import errors not showing on UI (apache#61163)
1262bf0 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
vincbeck pushed a commit that referenced this pull request Jan 29, 2026
@vatsrahul1001
Fix import errors not showing on UI (#61163) (#61213)
dd1a865 
Import error stopped showing on UI after #60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
@vatsrahul1001
Fix import errors not showing on UI (apache#61163)
34dc119 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
@vatsrahul1001 @jason810496
Fix import errors not showing on UI (apache#61163)
511fdef 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@vatsrahul1001 @jhgoebbert
Fix import errors not showing on UI (apache#61163)
ac43144 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@vatsrahul1001 @choo121600
Fix import errors not showing on UI (apache#61163)
3ba1b98 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@vatsrahul1001 @Subham-KRLX
Fix import errors not showing on UI (apache#61163)
7d0a66d 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@vatsrahul1001 @Ankurdeewan
Fix import errors not showing on UI (apache#61163)
f993c41 
Import error stopped showing on UI after apache#60801 which removed the early bypass for users with access to all DAGs.

When a DAG file has an import error, the DAG doesn't exist in DagModel (because it failed to import). The inner join with DagModel filters out these import errors because there's no matching row.

This was always broken for users without "read all" permissions but was masked by the early return path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ephraimbuddy ephraimbuddy ephraimbuddy approved these changes

@vincbeck vincbeck vincbeck approved these changes

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

@choo121600 choo121600 Awaiting requested review from choo121600 choo121600 is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Milestone

Airflow 3.1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@vatsrahul1001 @ephraimbuddy @vincbeck