Skip to content

Added timezone to dates#60391

Merged
bbovenzi merged 1 commit into
apache:mainfrom
sarth-akvaish:fix/RunId-Timezone-offset
Jan 15, 2026
Merged

Added timezone to dates#60391
bbovenzi merged 1 commit into
apache:mainfrom
sarth-akvaish:fix/RunId-Timezone-offset

Conversation

@sarth-akvaish

@sarth-akvaish sarth-akvaish commented Jan 11, 2026

Copy link
Copy Markdown
Contributor

This PR adds the timezone selector in the Navbar using the exisiting menu item which is present in the users list.

Fixes : #60302

Screenshot from 2026-01-15 12-53-00

Video

Screencast.from.2026-01-15.12-52-38.mp4

Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 11, 2026
@sarth-akvaish sarth-akvaish force-pushed the fix/RunId-Timezone-offset branch from 282ae94 to fe9b325 Compare January 11, 2026 15:33
@bbovenzi

Copy link
Copy Markdown
Contributor

I would prefer that we not add the timezone onto every single datetime in the UI.

If we think that the timezone needs to always be shown, then I would prefer that we integrate it into the nav bar under "User" similar to how it worked in Airflow 2.

@erinforman

Copy link
Copy Markdown

I would prefer that we not add the timezone onto every single datetime in the UI.

If we think that the timezone needs to always be shown, then I would prefer that we integrate it into the nav bar under "User" similar to how it worked in Airflow 2.

@bbovenzi i think that's fair. if i had to distill my expectation in the original issue: the timezone of timestamps in run IDs should match the timezone of dates/timestamps shown elsewhere in the UI. if that consistency is guaranteed, then we don't need timezone displayed on every single datetime. putting it in one place (like the nav bar) is fine.

@sarth-akvaish

sarth-akvaish commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback.
Before I proceed, I want to clarify the expected direction.
Would you prefer that :

  1. The run_id is formatted only in the UI layer
    (using the existing run_id value but displaying it in a user-friendly/timezone-consistent form),
    or
  2. The run_id format itself should be changed at creation time.( In this case it will affect api endpoints)

@bbovenzi

bbovenzi commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

RunId should not be altered.

Instead, we should take the timezone selector out of the user menu in the left-hand nav bar. And move it to its own button right about "User". The button's text will have the current timezone so that the user always has the TZ at-a-glance.

@sarth-akvaish sarth-akvaish force-pushed the fix/RunId-Timezone-offset branch from fe9b325 to d0e6cd5 Compare January 14, 2026 14:40
@bbovenzi

Copy link
Copy Markdown
Contributor

Thanks! Do you mind adding a screenshot of the changes?

@sarth-akvaish

Copy link
Copy Markdown
Contributor Author

Updated the description.

@bbovenzi

Copy link
Copy Markdown
Contributor

The timezone location label is always going to be too long. Let's just show the GMT offset (-5:00, +11:00, etc) and put anything else inside a tooltip.

@sarth-akvaish sarth-akvaish force-pushed the fix/RunId-Timezone-offset branch from d0e6cd5 to bb95b79 Compare January 15, 2026 07:24
@sarth-akvaish sarth-akvaish force-pushed the fix/RunId-Timezone-offset branch from bb95b79 to e5d4eac Compare January 15, 2026 10:40

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@bbovenzi bbovenzi merged commit 5a3c4fc into apache:main Jan 15, 2026
76 checks passed
@tirkarthi

Copy link
Copy Markdown
Contributor

Thanks for the PR. Airflow 2 had a clock on the header and it was easy to compare the current time in different timezone with the UI timestamps. Maybe it will good to add HH:MM also to be displayed that is updated every minute as a potential enhancement.

@tirkarthi

Copy link
Copy Markdown
Contributor

Minor nit: It seems button uses title props to display its own tooltip hence the offset tooltip from button is displayed on top of the current time tooltip hiding some content.

jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Airflow 3.1.x] Run ID displays raw timezone offset (+00:00) while datetime fields use formatted display without timezone indicator

4 participants