Fix KuberetesPodTriggerer use correct parameter name to read pod logs.#58489
Merged
jscheffl merged 2 commits intoNov 20, 2025
Conversation
AutomationDev85
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
Bot
added
area:providers
provider:cncf-kubernetes
jscheffl
approved these changes
Nov 19, 2025
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Ups. Thanks for the fix!
How can it be that this was not detected? In Pytest this is mocked... but is there another way to prevent a regression like this?
Contributor
Author
|
We could only detect this reliably with tests that exercise real Kubernetes API interactions in the triggerer. Implementing such integration tests would require substantially more time and resources than we currently have available. |
70 tasks
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
apache#58489) * Use correct parameter name in read_namespaced_pod_log call. * Fix unit test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
apache#58489) * Use correct parameter name in read_namespaced_pod_log call. * Fix unit test --------- Co-authored-by: AutomationDev85 <AutomationDev85>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
read_namespaced_pod_logexpects the container name in thecontainerparameter, notcontainer_name. The incorrect argument preventedKubernetesPodTriggerfrom fetching logs, causing the trigger to emit an error while the task kept running on the worker.Change Summary
containerargument when callingread_namespaced_pod_log.