Improve copy button usability on code blocks#56382
Merged
Merged
Conversation
RoyLee1224
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
Author
|
@NilsJPWerner Let me know what you think! |
RoyLee1224
changed the title
jscheffl
approved these changes
Oct 4, 2025
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Supporting this. Horizontal scrolling is not desired. Thanks for the fix.
hussein-awala
left a comment
hussein-awala
left a comment
Member
There was a problem hiding this comment.
+1 I like this change, but I can’t approve it since my TypeScript knowledge is limited.
guan404ming
approved these changes
Oct 5, 2025
Contributor
This is fantastic! |
bbovenzi
approved these changes
Oct 8, 2025
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
lgtm!
although, I wonder why the wrapLongLines wasn't working
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
(cherry picked from commit 0dca308) Co-authored-by: LI,JHE-CHEN <103923510+RoyLee1224@users.noreply.github.com>
Contributor
Backport successfully created: v3-1-test
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 8, 2025
(cherry picked from commit 0dca308) Co-authored-by: LI,JHE-CHEN <103923510+RoyLee1224@users.noreply.github.com>
jscheffl
pushed a commit
that referenced
this pull request
Oct 9, 2025
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
part of #56250
Why
Previously, for long lines of code, the copy button was pushed off-screen, forcing users to scroll horizontally to access it.
What
Now, if you hover on the code block, the button is always visible on the right edge of the container, regardless of horizontal scroll position.
Screenshots
code_before.mp4
code_after.mp4
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.