Fix log text selection contrast in light mode#56216
Merged
Merged
Conversation
Changed selection background from brand.subtle to gray.emphasized to improve readability when highlighting text in the log viewer. This aligns with the DAG code viewer styling and provides better contrast across both light and dark themes.
dheerajturaga
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
bbovenzi
reviewed
Sep 29, 2025
jscheffl
approved these changes
Sep 30, 2025
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
* Fix log text selection contrast in light mode Changed selection background from brand.subtle to gray.emphasized to improve readability when highlighting text in the log viewer. This aligns with the DAG code viewer styling and provides better contrast across both light and dark themes. * Brent's suggestions
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 20, 2025
* Fix log text selection contrast in light mode Changed selection background from brand.subtle to gray.emphasized to improve readability when highlighting text in the log viewer. This aligns with the DAG code viewer styling and provides better contrast across both light and dark themes. * Brent's suggestions (cherry picked from commit 8966d28)
Member
jscheffl
pushed a commit
that referenced
this pull request
Oct 20, 2025
* Fix log text selection contrast in light mode Changed selection background from brand.subtle to gray.emphasized to improve readability when highlighting text in the log viewer. This aligns with the DAG code viewer styling and provides better contrast across both light and dark themes. * Brent's suggestions (cherry picked from commit 8966d28) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove CSS prop to improve readability when highlighting text in the log viewer.
This aligns with the DAG code viewer styling and provides better
contrast across both light and dark themes.
Before: (yes the lines are highlighted but you cant see it!!)
After:
