Skip to content

[v3-0-test] Fix patch_task_instance endpoint (#50550) #50591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 2 commits into from
May 14, 2025
Merged

[v3-0-test] Fix patch_task_instance endpoint (#50550) #50591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c63549c
Fix patch_task_instance endpoint (#50550)
pierrejeambrun May 14, 2025
3c36c9a
Fix CI
pierrejeambrun May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions airflow-core/src/airflow/api_fastapi/core_api/openapi/v1-rest-api-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4484,8 +4484,9 @@ paths:
in: query
required: false
schema:
type: integer
default: -1
anyOf:
- type: integer
- type: 'null'
title: Map Index
- name: update_mask
in: query
Expand All @@ -4509,7 +4510,7 @@ paths:
content:
application/json:
schema:
$ref: '#/components/schemas/TaskInstanceResponse'
$ref: '#/components/schemas/TaskInstanceCollectionResponse'
'401':
content:
application/json:
Expand Down Expand Up @@ -5131,7 +5132,9 @@ paths:
in: path
required: true
schema:
type: integer
anyOf:
- type: integer
- type: 'null'
title: Map Index
- name: update_mask
in: query
Expand All @@ -5155,7 +5158,7 @@ paths:
content:
application/json:
schema:
$ref: '#/components/schemas/TaskInstanceResponse'
$ref: '#/components/schemas/TaskInstanceCollectionResponse'
'401':
content:
application/json:
Expand Down Expand Up @@ -5724,7 +5727,9 @@ paths:
in: path
required: true
schema:
type: integer
anyOf:
- type: integer
- type: 'null'
title: Map Index
- name: update_mask
in: query
Expand Down Expand Up @@ -5811,8 +5816,9 @@ paths:
in: query
required: false
schema:
type: integer
default: -1
anyOf:
- type: integer
- type: 'null'
title: Map Index
- name: update_mask
in: query
Expand Down
21 changes: 17 additions & 4 deletions airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,10 +790,13 @@ def patch_task_instance_dry_run(
dag_bag: DagBagDep,
body: PatchTaskInstanceBody,
session: SessionDep,
map_index: int = -1,
map_index: int | None = None,
update_mask: list[str] | None = Query(None),
) -> TaskInstanceCollectionResponse:
"""Update a task instance dry_run mode."""
if map_index is None:
map_index = -1

dag, ti, data = _patch_ti_validate_request(
dag_id, dag_run_id, task_id, dag_bag, body, session, map_index, update_mask
)
Expand Down Expand Up @@ -859,10 +862,13 @@ def patch_task_instance(
body: PatchTaskInstanceBody,
user: GetUserDep,
session: SessionDep,
map_index: int = -1,
map_index: int | None = None,
update_mask: list[str] | None = Query(None),
) -> TaskInstanceResponse:
) -> TaskInstanceCollectionResponse:
"""Update a task instance."""
if map_index is None:
map_index = -1

dag, ti, data = _patch_ti_validate_request(
dag_id, dag_run_id, task_id, dag_bag, body, session, map_index, update_mask
)
Expand Down Expand Up @@ -909,4 +915,11 @@ def patch_task_instance(
ti.task_instance_note.user_id = user.get_id()
session.commit()

return TaskInstanceResponse.model_validate(ti)
return TaskInstanceCollectionResponse(
task_instances=[
TaskInstanceResponse.model_validate(
ti,
)
],
total_entries=1,
)
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/ui/openapi-gen/queries/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4001,7 +4001,7 @@ export const useDagServicePatchDag = <
* @param data.requestBody
* @param data.mapIndex
* @param data.updateMask
* @returns TaskInstanceResponse Successful Response
* @returns TaskInstanceCollectionResponse Successful Response
* @throws ApiError
*/
export const useTaskInstanceServicePatchTaskInstance = <
Expand Down Expand Up @@ -4060,7 +4060,7 @@ export const useTaskInstanceServicePatchTaskInstance = <
* @param data.mapIndex
* @param data.requestBody
* @param data.updateMask
* @returns TaskInstanceResponse Successful Response
* @returns TaskInstanceCollectionResponse Successful Response
* @throws ApiError
*/
export const useTaskInstanceServicePatchTaskInstance1 = <
Expand Down
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/ui/openapi-gen/requests/services.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1918,7 +1918,7 @@ export class TaskInstanceService {
* @param data.requestBody
* @param data.mapIndex
* @param data.updateMask
* @returns TaskInstanceResponse Successful Response
* @returns TaskInstanceCollectionResponse Successful Response
* @throws ApiError
*/
public static patchTaskInstance(data: PatchTaskInstanceData): CancelablePromise<PatchTaskInstanceResponse> {
Expand Down Expand Up @@ -2192,7 +2192,7 @@ export class TaskInstanceService {
* @param data.mapIndex
* @param data.requestBody
* @param data.updateMask
* @returns TaskInstanceResponse Successful Response
* @returns TaskInstanceCollectionResponse Successful Response
* @throws ApiError
*/
public static patchTaskInstance1(
Expand Down
16 changes: 8 additions & 8 deletions airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2197,13 +2197,13 @@ export type GetTaskInstanceResponse = TaskInstanceResponse;
export type PatchTaskInstanceData = {
dagId: string;
dagRunId: string;
mapIndex?: number;
mapIndex?: number | null;
requestBody: PatchTaskInstanceBody;
taskId: string;
updateMask?: Array<string> | null;
};

export type PatchTaskInstanceResponse = TaskInstanceResponse;
export type PatchTaskInstanceResponse = TaskInstanceCollectionResponse;

export type GetMappedTaskInstancesData = {
dagId: string;
Expand Down Expand Up @@ -2281,13 +2281,13 @@ export type GetMappedTaskInstanceResponse = TaskInstanceResponse;
export type PatchTaskInstance1Data = {
dagId: string;
dagRunId: string;
mapIndex: number;
mapIndex: number | null;
requestBody: PatchTaskInstanceBody;
taskId: string;
updateMask?: Array<string> | null;
};

export type PatchTaskInstance1Response = TaskInstanceResponse;
export type PatchTaskInstance1Response = TaskInstanceCollectionResponse;

export type GetTaskInstancesData = {
dagId: string;
Expand Down Expand Up @@ -2356,7 +2356,7 @@ export type PostClearTaskInstancesResponse = TaskInstanceCollectionResponse;
export type PatchTaskInstanceDryRunData = {
dagId: string;
dagRunId: string;
mapIndex: number;
mapIndex: number | null;
requestBody: PatchTaskInstanceBody;
taskId: string;
updateMask?: Array<string> | null;
Expand All @@ -2367,7 +2367,7 @@ export type PatchTaskInstanceDryRunResponse = TaskInstanceCollectionResponse;
export type PatchTaskInstanceDryRun1Data = {
dagId: string;
dagRunId: string;
mapIndex?: number;
mapIndex?: number | null;
requestBody: PatchTaskInstanceBody;
taskId: string;
updateMask?: Array<string> | null;
Expand Down Expand Up @@ -4198,7 +4198,7 @@ export type $OpenApiTs = {
/**
* Successful Response
*/
200: TaskInstanceResponse;
200: TaskInstanceCollectionResponse;
/**
* Bad Request
*/
Expand Down Expand Up @@ -4393,7 +4393,7 @@ export type $OpenApiTs = {
/**
* Successful Response
*/
200: TaskInstanceResponse;
200: TaskInstanceCollectionResponse;
/**
* Bad Request
*/
Expand Down
Loading