-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Add Pushing XComs from Deferred example
#49535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
guan404ming
wants to merge
1
commit into
apache:main
from
guan404ming:add-pushing-xcoms-from-deferred-example
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an easy way to generate a list of all our Trigger that were written before 2.10 and don't support this? so we can patch them? in ~1 week or so the min version for providers will be 2.10 so we can safely fix it.
Also maybe, an idea how to get the list... adding a test to make sure any sub class of BaseTrigger has implementation for this? That would also protect us for future adding new triggers
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late. It took some time to deal with this. And I think this func is not supported for all triggers before 2.10.0 since there are not implementation of some thing like
self.xcomsor something like the example do.I only see the trigger test which use the functionality the example show
airflow/airflow-core/tests/unit/models/test_trigger.py
Lines 202 to 211 in c37e6eb
please let me know if there is anything I could help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my point. Minimum version for Airflow in providers is 2.10 so we should open a tracking issue to modify all trigger we have to support it. Don't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After more investigation, it seems currently trigger is not accept
xcoms#46677 (comment) after reworked.xcomsis passed when the event havexcoms.Should we modify our example or try to modify trigger to accept "xcoms" when init?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could leave this here until there is any re-implementation plan.