Skip to content

Fix DayOfWeekSensor use_task_logical_date condition#47825

Merged
kaxil merged 2 commits into
apache:mainfrom
gopidesupavan:fix-dayofweek-sensor
Mar 16, 2025
Merged

Fix DayOfWeekSensor use_task_logical_date condition#47825
kaxil merged 2 commits into
apache:mainfrom
gopidesupavan:fix-dayofweek-sensor

Conversation

@gopidesupavan

Copy link
Copy Markdown
Member

closes #47717
using run_after from dag run.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bugraoz93 bugraoz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small nit related to version check

Comment thread providers/standard/tests/unit/standard/sensors/test_weekday.py
@kaxil kaxil merged commit 60f6a9f into apache:main Mar 16, 2025
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
@gopidesupavan gopidesupavan deleted the fix-dayofweek-sensor branch May 28, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DayOfWeekSensor is failing when logical date is null and argument 'use_task_logical_date' is True

3 participants