Skip to content

Handle null logical date in TimeDeltaSensorAsync#47652

Merged
dstandish merged 13 commits into
apache:mainfrom
astronomer:time-delta-async-handle-logical-date-null
Mar 17, 2025
Merged

Handle null logical date in TimeDeltaSensorAsync#47652
dstandish merged 13 commits into
apache:mainfrom
astronomer:time-delta-async-handle-logical-date-null

Conversation

@dstandish

@dstandish dstandish commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

We can use run_after in this case.

Closes: #47384

Comment thread providers/standard/src/airflow/providers/standard/sensors/time_delta.py Outdated

@jedcunningham jedcunningham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we should test this?

Comment thread providers/standard/docs/sensors/datetime.rst Outdated
Comment thread providers/standard/docs/sensors/datetime.rst Outdated
Comment thread providers/standard/src/airflow/providers/standard/sensors/time_delta.py Outdated
@kaxil kaxil force-pushed the time-delta-async-handle-logical-date-null branch from 05326e3 to 0dbdc55 Compare March 13, 2025 17:12
@kaxil

kaxil commented Mar 13, 2025

Copy link
Copy Markdown
Member

Is this ready @dstandish ? I just rebased it to fix CI failures that were fixed in main

@dstandish

Copy link
Copy Markdown
Contributor Author

Is this ready @dstandish ? I just rebased it to fix CI failures that were fixed in main

think so. added tests.

@dstandish dstandish force-pushed the time-delta-async-handle-logical-date-null branch from 0dbdc55 to d03d464 Compare March 14, 2025 14:09
dstandish and others added 12 commits March 15, 2025 07:25
We can use run_after in this case.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@dstandish dstandish force-pushed the time-delta-async-handle-logical-date-null branch from e0f6585 to 0125087 Compare March 15, 2025 14:26
@dstandish dstandish merged commit 779b76b into apache:main Mar 17, 2025
@dstandish dstandish deleted the time-delta-async-handle-logical-date-null branch March 17, 2025 12:37
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
We can use run_after in this case.

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
We can use run_after in this case.

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TimeDeltaSensorAsync is failing when logical_date is null

6 participants