Switch to non-interactive mode where stdin is disabled#47568
Merged
jscheffl merged 2 commits intoMar 12, 2025
Conversation
majorosdonat
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
Bot
added
area:providers
provider:cncf-kubernetes
bugraoz93
reviewed
Mar 10, 2025
bugraoz93
left a comment
bugraoz93
left a comment
Contributor
There was a problem hiding this comment.
Could you please check the tests? Seems some mocks now behaving differently.
TypeError: the JSON object must be str, bytes or bytearray, not MagicMock
Contributor
|
Note: failed test also failing on main - AWS failures in CI are un-related to the PR. |
bugraoz93
approved these changes
Mar 12, 2025
bugraoz93
left a comment
bugraoz93
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating the test! Looks good. Rebase would be amazing!
potiuk
approved these changes
Mar 12, 2025
Member
|
Yep. Rebase would be great. |
jscheffl
force-pushed
the
bugfix/fix-unstable-xcom-upload
branch
from
af2d846 to
0ae4676
Compare
jscheffl
approved these changes
Mar 12, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 13, 2025
* Switch to non-interactive mode where stdin is disabled * fix tests --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Switch to non-interactive mode where stdin is disabled * fix tests --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xcom upload is not stable when using kubernetes stream in interactive mode. Looks like its an issue in the kubernetes client library. switched to non-interactive mode where stdin is disabled as suggested in the open issue thread.
Fixes: #39267
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.