Skip to content

Introduce breeze doctor#46664

Merged
potiuk merged 19 commits into
apache:mainfrom
kunaljubce:introduce-breeze-doctor
Mar 1, 2025
Merged

Introduce breeze doctor#46664
potiuk merged 19 commits into
apache:mainfrom
kunaljubce:introduce-breeze-doctor

Conversation

@kunaljubce

@kunaljubce kunaljubce commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

Intends to close #45975.

  • Introduce breeze doctor to troubleshoot common issues of breeze and reset the environment.
  • Remove --project-name parameter from breeze down

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kunaljubce kunaljubce changed the title Introduce breeze doctor [WIP] Introduce breeze doctor Feb 12, 2025
@potiuk

potiuk commented Feb 12, 2025

Copy link
Copy Markdown
Member

good start :)

Comment thread dev/breeze/src/airflow_breeze/commands/developer_commands.py Outdated
@kunaljubce

Copy link
Copy Markdown
Contributor Author

@potiuk Do we need to cleanup_python_generated_files() as part of breeze doctor?

@potiuk

potiuk commented Feb 16, 2025

Copy link
Copy Markdown
Member

@potiuk Do we need to cleanup_python_generated_files() as part of breeze doctor?

Yeah. Let's just clean absolutely everything we can. Also we might run fix_ownership_using_docker

@kunaljubce kunaljubce changed the title [WIP] Introduce breeze doctor Introduce breeze doctor Feb 16, 2025
@kunaljubce

Copy link
Copy Markdown
Contributor Author

@potiuk Do we need to cleanup_python_generated_files() as part of breeze doctor?

Yeah. Let's just clean absolutely everything we can. Also we might run fix_ownership_using_docker

@potiuk Done! Please review the PR and add your feedback/suggestions.

@potiuk

potiuk commented Feb 27, 2025

Copy link
Copy Markdown
Member

One small comment only. Possibly we should add "confirm" method call for every step? The way it is implemented now, It always performs all cleanup, but maybe it's enough to only do some of that and get interactive. That can be paired with --answer flag:

  • breeze doctor -> interactively asking about each step allowing to y -> do it, n -> skip it, q -> quit the process
  • breeze doctor --answer y -> perform complete cleanup

@kunaljubce kunaljubce marked this pull request as ready for review February 28, 2025 07:20
@kunaljubce

Copy link
Copy Markdown
Contributor Author

One small comment only. Possibly we should add "confirm" method call for every step? The way it is implemented now, It always performs all cleanup, but maybe it's enough to only do some of that and get interactive. That can be paired with --answer flag:

  • breeze doctor -> interactively asking about each step allowing to y -> do it, n -> skip it, q -> quit the process
  • breeze doctor --answer y -> perform complete cleanup

@potiuk Thanks for your feedback, have added these options now. Lemme know your thoughts :) Also adding @rawwar in this conversation, to try it out and share feedback.

@kunaljubce

Copy link
Copy Markdown
Contributor Author

I see the failures, will check them out shortly 😮‍💨

@rawwar

rawwar commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

Awesome! I am just noticing this PR. Thanks for tagging me @kunaljubce

@kunaljubce

Copy link
Copy Markdown
Contributor Author

I see the failures, will check them out shortly 😮‍💨

Seems like the failures are related to the apache-kafka==2.8.1 issue, should be resolved now that PR #47204 is merged. Rebased this feature branch with main and rerunning the tests.

Comment thread dev/breeze/src/airflow_breeze/commands/developer_commands.py
Comment thread dev/breeze/src/airflow_breeze/commands/developer_commands_config.py Outdated
@potiuk

potiuk commented Mar 1, 2025

Copy link
Copy Markdown
Member

NICE!

@potiuk potiuk merged commit f4e8f86 into apache:main Mar 1, 2025
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Mar 5, 2025
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add breeze doctor sub-command for troubleshooting

3 participants