More meaningful @task.kubernetes pod naming#46535
Merged
Merged
Conversation
- use decorated `python_callable.__name__` as part of the name created for pod by default. - drop `uuid` usage in favor of present `random_name_suffix` argument
boring-cyborg
Bot
added
the
provider:cncf-kubernetes
Contributor
Author
|
@RNHTTR I am sorry to bother you, but do you mind taking a look at the re-creation of the previous PR already approved by you? I've messed up a ton with rebasing for the new providers structure, so I've re-created it. Also, the The changes are the same, and now the tests are green after fixes in |
2 tasks
potiuk
approved these changes
Feb 8, 2025
Member
|
Nice! |
Contributor
|
Nice one @insomnes ! |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* More meaningful default name for @task.kubernetes pods - use decorated `python_callable.__name__` as part of the name created for pod by default. - drop `uuid` usage in favor of present `random_name_suffix` argument * Update task.kubernetes decorator doc-string
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use name based on decorated python callable in
@task.kubernetespod name generationrandom_name_suffixargumentname=Noneand nonameargument providedRe-implementation of the previous PR messed up by new providers structure rebasing
#46462
closes: #46464
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.