Skip to content

Limit google-cloud-aiplatform to fix issues in CI#46242

Merged
jscheffl merged 5 commits into
apache:mainfrom
amoghrajesh:add-sklearn-to-google
Jan 29, 2025
Merged

Limit google-cloud-aiplatform to fix issues in CI#46242
jscheffl merged 5 commits into
apache:mainfrom
amoghrajesh:add-sklearn-to-google

Conversation

@amoghrajesh

Copy link
Copy Markdown
Contributor

From the last failure https://github.com/apache/airflow/actions/runs/13032455156/job/36355532907, looks like sklearn is not a dependency on google provider. Using the latest stable version: https://scikit-learn.org/stable/auto_examples/release_highlights/plot_release_highlights_1_6_0.html


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh amoghrajesh requested a review from potiuk January 29, 2025 15:13
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Jan 29, 2025
Comment thread generated/provider_dependencies.json Outdated
@amoghrajesh amoghrajesh changed the title Adding sklearn as a dependency for google provider Limit google-cloud-aiplatform to fix issues in CI Jan 29, 2025
@potiuk

potiuk commented Jan 29, 2025

Copy link
Copy Markdown
Member

Can you also create an issue for that so we do not forget to take care of that later ?

@jscheffl

Copy link
Copy Markdown
Contributor

Seems next canary is also failing as the PR is open: https://github.com/apache/airflow/actions/runs/13038931877/job/36376833483

@amoghrajesh

Copy link
Copy Markdown
Contributor Author

I think we can merge if failures are unrelated to unblock

Comment thread providers/src/airflow/providers/google/provider.yaml

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jscheffl

Copy link
Copy Markdown
Contributor

Merging. All errors in CI checks are residual leftovers of other problems, this PR still improves the broken main state.

@jscheffl jscheffl merged commit e3baba0 into apache:main Jan 29, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Jan 30, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
* Adding sklearn as a dependency for google provider

* limiting google cloud aiplatform instead

* Add link to bug ticket

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants