Fix DbApiHook.insert_rows logging incorrect number of rows commited#45789
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Lee-W
reviewed
Jan 22, 2025
Lee-W
left a comment
Member
There was a problem hiding this comment.
would it be possible for us to add a test here?
Contributor
Author
I've added a test but I am not really sure how to run it. |
Lee-W
approved these changes
Jan 27, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
josix
pushed a commit
to josix/airflow
that referenced
this pull request
Jan 27, 2025
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…pache#45789) * Fix DbApiHook.insert_rows logging incorrect number of rows commited * add test for checking the log message matches the amount of rows committed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DbApiHook.insert_rowsis logging the incorrect number of commited rows whenexecutemanyis supported by the database.The current behavior is like this:
Since it says 'so far', logging the accumulated number of rows commited makes more sense:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.