Skip to content

AIP-84 Get Mapped Task Instance Tries#44303

Merged
pierrejeambrun merged 8 commits into
apache:mainfrom
kandharvishnu:AIP-84_get_mapped_task_instance_tries
Nov 26, 2024
Merged

AIP-84 Get Mapped Task Instance Tries#44303
pierrejeambrun merged 8 commits into
apache:mainfrom
kandharvishnu:AIP-84_get_mapped_task_instance_tries

Conversation

@kandharvishnu

Copy link
Copy Markdown
Contributor

related to: #42370


@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 23, 2024
@rawwar rawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 23, 2024
@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_tries branch from 1b5e318 to 3c81dd4 Compare November 23, 2024 13:10
Comment thread airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated
Comment thread airflow/api_fastapi/core_api/routes/public/task_instances.py
Comment thread airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thanks :)

Should be good to merge once the base branch is updated and merged.

I'll do a final review then.

@pierrejeambrun

Copy link
Copy Markdown
Member

Need rebasing and conflict solving.

@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_tries branch from a22e190 to bb4d86b Compare November 26, 2024 13:23
@kandharvishnu kandharvishnu requested a review from a user November 26, 2024 13:23

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

Comment thread airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated
@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_tries branch from b1f680a to 6879cf6 Compare November 26, 2024 14:39
@pierrejeambrun pierrejeambrun merged commit a238d06 into apache:main Nov 26, 2024
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* adding get_task_instance_tries code

* rebase

* rebase

* adding get_mapped_task_instance_tries code

* adding mark_fastapi_migration_done

* rebasing test cases

* rebasing task_instances.py

* updating map_index default value

---------

Co-authored-by: kandharvishnuu <148410552+kandharvishnuu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants