AIP-84: Migrate get_log endpoint#44238
Merged
Merged
Conversation
utkarsharma2
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
utkarsharma2
force-pushed
the
migrate_log_endpoint
branch
from
5d29904 to
6996c71
Compare
rawwar
reviewed
Nov 21, 2024
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Nice thanks !
A few suggestions and ready to merge :)
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
rawwar
reviewed
Nov 21, 2024
rawwar
reviewed
Nov 21, 2024
Co-authored-by: Kalyan R <kalyan.ben10@live.com>
utkarsharma2
commented
Nov 21, 2024
rawwar
reviewed
Nov 21, 2024
rawwar
reviewed
Nov 21, 2024
rawwar
reviewed
Nov 21, 2024
rawwar
reviewed
Nov 21, 2024
rawwar
reviewed
Nov 21, 2024
rawwar
reviewed
Nov 21, 2024
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Minor nitpick, after addressing @rawwar suggestions, should be good to merge.
rawwar
reviewed
Nov 22, 2024
rawwar
approved these changes
Nov 22, 2024
1 task
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Migrate log endpoint * Remove debug commit * Update tests/api_fastapi/core_api/routes/public/test_task_instances.py Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * Update tests/api_fastapi/core_api/routes/public/test_task_instances.py Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * Update airflow/api_fastapi/core_api/datamodels/task_instances.py Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * Update tests/api_fastapi/core_api/routes/public/test_task_instances.py Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * Remove code comments * Address PR comments * Remove unwanted code * Address PR comments * Update airflow/api_fastapi/core_api/routes/public/log.py Co-authored-by: Kalyan R <kalyan.ben10@live.com> * Update airflow/api_fastapi/core_api/datamodels/log.py * Fix static check * Address PR comments * Address PR comments --------- Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Kalyan R <kalyan.ben10@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #42370