Migrate public endpoint Get Airflow Version to FastAPI#43312
Merged
Conversation
omkar-foss
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
bbovenzi
approved these changes
Oct 23, 2024
jscheffl
approved these changes
Oct 23, 2024
Comment on lines
+33
to
+34
| version_info = VersionInfo(version=airflow_version, git_version=git_version) | ||
| return VersionInfo.model_validate(version_info) |
Member
There was a problem hiding this comment.
Here you don't need to revalidate the version_info. Validation is done at instanciation of VersionInfo.
return VersionInfo(...)
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Migrate public endpoint Get Airflow Version to FastAPI * Run static checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #42879
related: #42370
This migrates the Get Airflow Version API from
api_connexiontoapi_fastapi.