Migrate the public endpoint Get DAG Stats to FastAPI#43255
Merged
Conversation
omkar-foss
force-pushed
the
aip-84/dags/get-dag-stats
branch
3 times, most recently
from
7519fd1 to
a3a80ec
Compare
omkar-foss
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
approved these changes
Oct 23, 2024
pierrejeambrun
requested changes
Oct 24, 2024
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Looking good. A few suggestions and we should be good to merge.
omkar-foss
force-pushed
the
aip-84/dags/get-dag-stats
branch
from
91ba57f to
440180c
Compare
omkar-foss
force-pushed
the
aip-84/dags/get-dag-stats
branch
from
9873a00 to
56faf48
Compare
Collaborator
Author
|
@pierrejeambrun All comments resolved, please have a look when possible. Thank you! |
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
We are missing the @mark_fastapi_migration_done decorator
omkar-foss
force-pushed
the
aip-84/dags/get-dag-stats
branch
from
56faf48 to
22b234d
Compare
omkar-foss
added
the
legacy api
Collaborator
Author
Done, added it. And have added |
Collaborator
Author
|
@pierrejeambrun all conversations and conflicts resolved, PR ready to review ✅ Also kindly see this thread, let me know if any changes needed there: #43255 (comment) |
Member
|
Need rebasing but can be merged after that. |
omkar-foss
force-pushed
the
aip-84/dags/get-dag-stats
branch
from
330db0c to
47dd7d5
Compare
Collaborator
Author
@pierrejeambrun done, PR rebased and synced with |
Member
|
Thanks @omkar-foss |
pierrejeambrun
approved these changes
Nov 5, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Migrate public endpoint Get DAG Stats to FastAPI, with main resynced * Re-run static checks * Add newlines to separate entities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #42877
related: #42370
This migrates the Get DAG Stats API from
api_connexiontoapi_fastapi.