Skip to content

Fix intermittent failure in UI Time test#43147

Merged
bbovenzi merged 1 commit into
apache:mainfrom
omkar-foss:fix-ui-time-test
Oct 18, 2024
Merged

Fix intermittent failure in UI Time test#43147
bbovenzi merged 1 commit into
apache:mainfrom
omkar-foss:fix-ui-time-test

Conversation

@omkar-foss

Copy link
Copy Markdown
Collaborator

closes: #43146

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 18, 2024
@omkar-foss

Copy link
Copy Markdown
Collaborator Author

cc: @bbovenzi just for your info! :)

@omkar-foss omkar-foss marked this pull request as ready for review October 18, 2024 08:15
@omkar-foss

omkar-foss commented Oct 18, 2024

Copy link
Copy Markdown
Collaborator Author

Hi! Looks like we've an intermittent test failure, while fixing another intermittent test failure 😂
https://github.com/apache/airflow/actions/runs/11399892797/job/31720011364?pr=43147

Trying to re-trigger the tests now.

@omkar-foss omkar-foss closed this Oct 18, 2024
@omkar-foss omkar-foss reopened this Oct 18, 2024
@omkar-foss omkar-foss closed this Oct 18, 2024
@omkar-foss omkar-foss reopened this Oct 18, 2024
@omkar-foss

omkar-foss commented Oct 18, 2024

Copy link
Copy Markdown
Collaborator Author

Hi! Looks like we've an intermittent test failure, while fixing another intermittent test failure 😂 https://github.com/apache/airflow/actions/runs/11399892797/job/31720011364?pr=43147

Trying to re-trigger the tests now.

Doesn't look like an intermittent failure, I tried again twice, it's still failing. Weird thing that it's passing in my other PR #43084 which also is in sync with main 🤔

Failure seems to be related to logging module, I'll try to dig deeper.

@omkar-foss omkar-foss closed this Oct 18, 2024
@omkar-foss omkar-foss reopened this Oct 18, 2024
@omkar-foss omkar-foss closed this Oct 18, 2024
@omkar-foss omkar-foss reopened this Oct 18, 2024

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@bbovenzi

Copy link
Copy Markdown
Contributor

I'm still going to merge. Let's get rid of at least one intermittent failure

@bbovenzi bbovenzi merged commit 3f52c83 into apache:main Oct 18, 2024
@pierrejeambrun

Copy link
Copy Markdown
Member

Yes and the other one is unrelated and need separate fixing I believe.

@omkar-foss omkar-foss deleted the fix-ui-time-test branch October 18, 2024 14:30
@omkar-foss

Copy link
Copy Markdown
Collaborator Author

Yes and the other one is unrelated and need separate fixing I believe.

Yes, and the failing non-db tests command passes well on my local breeze. Also other PRs don't seem to be having this failure, which makes it even weirder! 😅

harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix intermittent failure in React UI Time test

3 participants