Remove a portion of PR #41531 (retrieve output from swarm), added xcom support for Docker swarm logs#43006
Closed
spoutin wants to merge 5 commits into
Closed
Remove a portion of PR #41531 (retrieve output from swarm), added xcom support for Docker swarm logs#43006spoutin wants to merge 5 commits into
spoutin wants to merge 5 commits into
Conversation
do_xcom_all will return the entire output from the docker container and pass it to xcom otherwise only the last line will be returned.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Author
|
closing since I bug, will recreate a new pull reqeust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Add retrieve output docker swarm operator #41531 doesn't work on a mutli node environment since
inspect_containerfrom the docker sdk will not work if the docker container did run on the node which call the api. This results in a container not found error preventing the Operator from running. The code was since been removed since there is no way to guarantee the placement of the docker container.adding Xcom support for docker logs. If do_xcom_push is true (default) the last line of the docker logs will be push to the xcom results. If xcom_all is set to true, all results will be push to xcom.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.