Pre commit script to validate template fields#42284
Merged
vincbeck merged 3 commits intoSep 27, 2024
Merged
Conversation
gopidesupavan
requested review from
ashb,
jedcunningham and
potiuk
as code owners
vincbeck
approved these changes
Sep 18, 2024
gopidesupavan
force-pushed
the
ci-script-to-validate-template-fields
branch
2 times, most recently
from
e6a25a2 to
5eb4b57
Compare
Member
Author
|
There is one test failing not related to this change. |
gopidesupavan
force-pushed
the
ci-script-to-validate-template-fields
branch
from
5eb4b57 to
88e7cec
Compare
Member
Author
|
The tests are running fine after rebase. |
Member
|
Nice! |
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding CI script to check template fields in provider operators and sensors.
Raising new pr, I have created initial pr here #42230 , due to rebasing issues, its showing merged commits aswell in pr changes.
Sorry for the double review 😞
Retested again after changes:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.