Rename --extras to --airflow-extras from breeze prod-image build command

[vincbeck]

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[ferruzzi]

Looks like --extras was replaced with --airflow-extras in #23562 here so rather than remove it, maybe just update the correct new flag?

[vincbeck]

Looks like --extras was replaced with --airflow-extras in #23562 here so rather than remove it, maybe just update the correct new flag?

You're right, nice catch! The difference between airflow-extras and --additional-airflow-extras is not clear to me though

[ferruzzi]

The difference between airflow-extras and --additional-airflow-extras is not clear to me though

Yeah, I'm not 100% on the distinction there, but based on the documentation changes in that PR I linked I'm fairly confident that --airflow-extras was a direct replacement for -extras.

I think --additional* is supposed to append to the existing --airflow-extras, but I'm not sure.

[vincbeck]

Fixed :)

[potiuk]

Yeah, I'm not 100% on the distinction there, but based on the documentation changes in that PR I linked I'm fairly confident that --airflow-extras was a direct replacement for -extras.

I think --additional* is supposed to append to the existing --airflow-extras, but I'm not sure.

That was exactly the intention :). Any improvement to wording to explain it better is most welcome.

[ferruzzi]

Some checks aren't passing, but they don't look related. Feel free to merge once those go green.

[vincbeck]

Yeah, I'm not 100% on the distinction there, but based on the documentation changes in that PR I linked I'm fairly confident that --airflow-extras was a direct replacement for -extras.
I think --additional* is supposed to append to the existing --airflow-extras, but I'm not sure.

That was exactly the intention :). Any improvement to wording to explain it better is most welcome.

I meant what is the value of having --airflow-extras and --additional-airflow-extras and not only one. What is the difference between breeze prod-image build --airflow-extras extra1 --additional-airflow-extras extra2 and breeze prod-image build --airflow-extras extra1,extra2? It is more for my curiosity than a concern :)

[potiuk]

--additional is when you want to add one or two providers to the default ones

--extraa is when you want to change the base set of extras

This makes a difference for example when you build slim image. Default PROD dockerfile adds about 20 or so extras (commonly used providers - Amazon, Google, etc.) . Slim image had only the pre installed providers which means that --extras is empty.

So in short : use --additional when you want to extend 'reference' image. Use --extras when you want to slim-down the basic set of extras that the reference image has

[vincbeck]

--additional is when you want to add one or two providers to the default ones

--extraa is when you want to change the base set of extras

This makes a difference for example when you build slim image. Default PROD dockerfile adds about 20 or so extras (commonly used providers - Amazon, Google, etc.) . Slim image had only the pre installed providers which means that --extras is empty.

So in short : use --additional when you want to extend 'reference' image. Use --extras when you want to slim-down the basic set of extras that the reference image has

That makes perfect sense! Thanks!