Skip to content

Fix issue generation failing after deleting a PR#42001

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-issue-generation-with-deleted-prs
Sep 4, 2024
Merged

Fix issue generation failing after deleting a PR#42001
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-issue-generation-with-deleted-prs

Conversation

@potiuk

@potiuk potiuk commented Sep 4, 2024

Copy link
Copy Markdown
Member

Seems that #41416 PR has been somehow (?) deleted and when we try to generate issue links for it, the issue generation fails (and it is not an issue as well). This change should workaround that by skipping the PR.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Seems that apache#41416 PR has been somehow (?) deleted and when we try
to generate issue links for it, the issue generation fails (and it
is not an issue as well). This change should workaround that by
skipping the PR.
@Lee-W

Lee-W commented Sep 4, 2024

Copy link
Copy Markdown
Member

Thanks @potiuk . This seems to block the ci for a while

@potiuk

potiuk commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

Thanks @potiuk . This seems to block the ci for a while

Yeah - see slack. Looks like the PR in question is gone - same as the contributor who created it. I will take a close look at the PR if there is nothing suspicious there. The account could be deleted by GitHubs "malware" automation detection, so let's see if there was something strange there .

Happened for the first time ever to see PR that is basically gone

@potiuk

potiuk commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

Nothing suspicious.

@potiuk potiuk merged commit d5467d6 into apache:main Sep 4, 2024
@potiuk potiuk deleted the fix-issue-generation-with-deleted-prs branch September 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants