fix: remove part of openlineage extraction from S3ToRedshiftOperator#41631
Merged
Conversation
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
boring-cyborg
Bot
added
area:providers
provider:amazon
eladkal
approved these changes
Aug 21, 2024
mobuchowski
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently the OpenLineage support for S3ToRedshiftOperator has been added. Upon closer inspection together with @Artuz37 we found out that some edge cases do not allow us to deduce the schema and column level lineage on s3 file, and the wildcard char in S3 does not work like some may expect, so we adjusted the OpenLineage extraction to provide only reliable lineage. Tests were adjusted to reflect that changes.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.