DRAFT Add task instance event log table#40761
Closed
dstandish wants to merge 3 commits into
Closed
Conversation
boring-cyborg
Bot
added
area:Executors-core
dstandish
changed the title
dstandish
force-pushed
the
add-task-event-log-table
branch
from
55e1079 to
1447e99
Compare
vincbeck
reviewed
Jul 15, 2024
vincbeck
left a comment
vincbeck
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall! Should we also deprecate/remove TaskContextLogger ?
Contributor
There was a problem hiding this comment.
Suggested change
| "ECS task %s has failed %s times. Marking as failed. Reasons: %s" % task_key, | |
| "ECS task %s has failed %s times. Marking as failed. Reasons: %s", |
And pass task_key as first parameter
dstandish
force-pushed
the
add-task-event-log-table
branch
from
1447e99 to
e1048d5
Compare
Contributor
Author
|
closing in favor of #40739 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft!