Skip to content

UI changes for DAG Reparsing feature#39636

Merged
utkarsharma2 merged 10 commits into
apache:mainfrom
astronomer:UI_DagReparsing
May 22, 2024
Merged

UI changes for DAG Reparsing feature#39636
utkarsharma2 merged 10 commits into
apache:mainfrom
astronomer:UI_DagReparsing

Conversation

@utkarsharma2

@utkarsharma2 utkarsharma2 commented May 15, 2024

Copy link
Copy Markdown
Contributor

This PR introduces the UI changes required to consume the DAG Reparsing API.

Home page

Screenshot 2024-05-15 at 4 59 07 PM

Detail page

Screenshot 2024-05-15 at 4 59 25 PM

related: #39138

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 15, 2024
@utkarsharma2 utkarsharma2 marked this pull request as draft May 15, 2024 11:30
utkarsharma2
utkarsharma2 commented May 15, 2024
View reviewed changes
Comment thread airflow/www/static/js/main.js Outdated
@phanikumv phanikumv added this to the Airflow 2.10.0 milestone May 15, 2024
utkarsharma2
utkarsharma2 commented May 16, 2024
View reviewed changes
Comment thread airflow/www/static/js/main.js Outdated
bbovenzi
bbovenzi reviewed May 16, 2024
View reviewed changes
Comment thread airflow/www/templates/airflow/dags.html Outdated
@utkarsharma2 utkarsharma2 marked this pull request as ready for review May 17, 2024 12:45
@utkarsharma2 utkarsharma2 requested a review from bbovenzi May 17, 2024 12:47
@eladkal

eladkal commented May 19, 2024

Copy link
Copy Markdown
Contributor

The icon might be misleading. It may be confused with refresh page

@raphaelauv

raphaelauv commented May 19, 2024

Copy link
Copy Markdown
Contributor

maybe something like

re_parse

@utkarsharma2

utkarsharma2 commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

maybe something like

re_parse

@raphaelauv To me, this looks like searching a file, but I'm not sure what would be better.
@bbovenzi Any suggestions?

@raphaelauv

raphaelauv commented May 20, 2024

Copy link
Copy Markdown
Contributor

@utkarsharma2 yes you are right

then this ?

image

@bbovenzi

bbovenzi commented May 20, 2024

Copy link
Copy Markdown
Contributor

@utkarsharma2 yes you are right

then this ?

image

Let's try it and see if it's not too detailed for the size we display it at.

@utkarsharma2

utkarsharma2 commented May 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@utkarsharma2 yes you are right

then this ?

image

I'm not able to find this icon in airflow's supported lib - https://materializecss.com/icons.html.

But the closest icon I could find looks like this -
Screenshot 2024-05-21 at 7 38 16 PM

Screenshot 2024-05-21 at 7 38 29 PM

@bbovenzi

bbovenzi commented May 21, 2024

Copy link
Copy Markdown
Contributor

Looks great to me!

Do the Dags list and dag details pages refresh once the DAG is reparsed?

@utkarsharma2

utkarsharma2 commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

Do the Dags list and dag details pages refresh once the DAG is reparsed?

Yes, the redirect URL part handles it, right now.

bbovenzi
bbovenzi approved these changes May 22, 2024
View reviewed changes

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@utkarsharma2 utkarsharma2 merged commit 2250a1a into apache:main May 22, 2024
@utkarsharma2 utkarsharma2 deleted the UI_DagReparsing branch May 22, 2024 17:13
@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jun 3, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@utkarsharma2 @romsharon98
UI changes for DAG Reparsing feature (apache#39636)
0fe790f 
* UI changes for DAG Reparsing feature

releated: apache#39138

* Add correct permission for UI

* Fix JS

* Update airflow/www/static/js/main.js

* Add a wrapper arounf REST DAG Reparsing API

* Move file_token from dag object to a separate field

* Fix CI issue

* Change icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes
@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton
@ashb ashb Awaiting requested review from ashb
@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features

Projects

None yet

Milestone

Airflow 2.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@utkarsharma2 @eladkal @raphaelauv @bbovenzi @phanikumv