Allow importing the aws executors with a shorter path#39093
Merged
o-nikolas merged 5 commits intoApr 18, 2024
Conversation
Import the aws executors in the __init__.py module of their respective directories so that they can be imported with a shorter and more natural looking module path. For example, this modules path: `airflow.providers.amazon.aws.executors.batch.batch_executor.AwsBatchExecutor` Becomes: `airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor`
boring-cyborg
Bot
added
area:providers
provider:amazon
o-nikolas
commented
Apr 17, 2024
o-nikolas
commented
Apr 17, 2024
eladkal
approved these changes
Apr 17, 2024
jedcunningham
approved these changes
Apr 17, 2024
syedahsn
approved these changes
Apr 17, 2024
jedcunningham
approved these changes
Apr 17, 2024
vincbeck
approved these changes
Apr 17, 2024
dirrao
approved these changes
Apr 18, 2024
dirrao
left a comment
dirrao
left a comment
Contributor
There was a problem hiding this comment.
LGTM. It's worth to add unit test with shorter path.
Contributor
|
Just an idea, maybe move it into the package root and make it lazy-loaded thought PEP-562, e.g. the same way as if does into the: |
Taragolis
reviewed
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import the aws executors in the
__init__.pymodule of their respective directories so that they can be imported with a shorter and more natural looking module path.For example, this modules path:
airflow.providers.amazon.aws.executors.batch.batch_executor.AwsBatchExecutorBecomes:
airflow.providers.amazon.aws.executors.batch.AwsBatchExecutorfixes #38524
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.