Rename SparkSubmitOperator argument queue as yarn_queue#38852
Merged
Lee-W merged 6 commits intoApr 11, 2024
Merged
Conversation
pateash
changed the title
pateash
changed the title
2 tasks
eladkal
approved these changes
Apr 9, 2024
eladkal
left a comment
eladkal
left a comment
Contributor
There was a problem hiding this comment.
I will highlight this change in the release notes for the provider as while it rename the parameter this is a bug fix rather than a breaking change
Contributor
pateash
force-pushed
the
38461-Applying-queue-with-SparkSubmitOperator-is-ignored
branch
from
a0bf52f to
d6bf819
Compare
pateash
force-pushed
the
38461-Applying-queue-with-SparkSubmitOperator-is-ignored
branch
from
d6bf819 to
218585b
Compare
Contributor
Author
Lee-W
approved these changes
Apr 11, 2024
Lee-W
changed the title
Lee-W
changed the title
pateash
deleted the
38461-Applying-queue-with-SparkSubmitOperator-is-ignored
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #38461
related: #35911
Description
We added a yarn queue parameter in SparkSubmitOperator in #35911,
but this parameter overrode BaseOperator value where a queue is an Airflow queue.
Proposed Fix/Solution
Renaming the argument in SparkSubmitOperator to avoid any confusion and issues going forward,
even though in Sparksubmit it's called '--queue'.