Limit importlib_resources as it breaks pytest_rewrites#38095
Merged
Conversation
potiuk
requested review from
hussein-awala and
pankajkoti
and removed request for
ashb and
jedcunningham
Member
Author
|
also fixes a typo in skipping images jobs (but that's secondary) |
New version of importlib_resources released today - 6.2.0 but also 6.3.0 released few hours later, break pytest_rewrite feature in rather unexpected ways. Until the problem is diagnosed and solved we should limit it. The issue is tracked in python/importlib_resources#299
hussein-awala
approved these changes
Mar 13, 2024
potiuk
force-pushed
the
limit-importlib-resources
branch
from
83b8a7f to
d394401
Compare
potiuk
force-pushed
the
limit-importlib-resources
branch
3 times, most recently
from
3aec930 to
4f265ec
Compare
dirrao
approved these changes
Mar 13, 2024
drajguru
pushed a commit
to drajguru/airflow
that referenced
this pull request
Mar 14, 2024
New version of importlib_resources released today - 6.2.0 but also 6.3.0 released few hours later, break pytest_rewrite feature in rather unexpected ways. Until the problem is diagnosed and solved we should limit it. The issue is tracked in python/importlib_resources#299
ephraimbuddy
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Mar 19, 2024
New version of importlib_resources released today - 6.2.0 but also 6.3.0 released few hours later, break pytest_rewrite feature in rather unexpected ways. Until the problem is diagnosed and solved we should limit it. The issue is tracked in python/importlib_resources#299 (cherry picked from commit 7ec2407)
jedcunningham
removed
the
changelog:skip
jedcunningham
added
the
type:misc/internal
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of importlib_resources released today - 6.2.0 but also 6.3.0 released few hours later, break pytest_rewrite feature in rather unexpected ways. Until the problem is diagnosed and solved we should limit it. The issue is tracked in
python/importlib_resources#299
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.