Skip to content

Add missing informative logs in KPO trigger until container has not finished #37546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pankajkoti merged 2 commits into from
Apr 24, 2024
Merged

Add missing informative logs in KPO trigger until container has not finished #37546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d08e5c0
Add informative logs in KPO trigger until container has not finished
pankajkoti Feb 19, 2024
87ee37b
Apply suggestions from code review
pankajkoti Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airflow/providers/cncf/kubernetes/triggers/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:
"last_log_time": self.last_log_time,
}
)
self.log.debug("Container is not completed and still working.")
Comment thread
pankajkoti marked this conversation as resolved.
Outdated
if time_get_more_logs and datetime.datetime.now(tz=datetime.timezone.utc) > time_get_more_logs:
return TriggerEvent(
{
Expand All @@ -271,6 +272,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:
"name": self.pod_name,
}
)
self.log.debug("Sleeping for %s seconds.", self.poll_interval)
await asyncio.sleep(self.poll_interval)

def _get_async_hook(self) -> AsyncKubernetesHook:
Expand Down