Add create_or_replace_document_objects method to weaviate provider#36177
Merged
Conversation
utkarsharma2
requested review from
ephraimbuddy,
pankajkoti,
phanikumv and
sunank200
mpgreg
suggested changes
Dec 12, 2023
mpgreg
left a comment
mpgreg
left a comment
There was a problem hiding this comment.
Looks great. Still need to address upsert needs and also error handling. See comments.
josh-fell
reviewed
Dec 13, 2023
sunank200
suggested changes
Dec 13, 2023
sunank200
left a comment
sunank200
left a comment
Collaborator
There was a problem hiding this comment.
In the ineFor ingesting data, it should determine objects to insert, objects to delete and objects that remain unchanged for each chunk. This would simplify the logic.
utkarsharma2
changed the title
sunank200
reviewed
Dec 20, 2023
josh-fell
reviewed
Dec 21, 2023
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
utkarsharma2
force-pushed
the
WeaviateIngest
branch
from
bb31a01 to
34b92ed
Compare
potiuk
approved these changes
Dec 22, 2023
josh-fell
approved these changes
Dec 22, 2023
This was referenced Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inserting the data into weaviate database, it's common to override the existing data, if users go about doing that themselves, there are lots of cases and API failures that need to be handled. This PR aims to provide a helper function that can handle all cases.