Skip to content

allow changing of config file from default for the KubernetesResourceBaseOperator#34819

Closed
chapm250 wants to merge 4 commits into
apache:mainfrom
chapm250:main
Closed

allow changing of config file from default for the KubernetesResourceBaseOperator#34819
chapm250 wants to merge 4 commits into
apache:mainfrom
chapm250:main

Conversation

@chapm250

@chapm250 chapm250 commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

Currently the KubernetesResourceBaseOperator doesn't allow changing from the default K8s config_file location (unlike the KubernetesPodOperator), this change allows changing the config_file location so airflow deployments with a non-default K8s config_file path can use the subclasses of the KubernetesResourceBaseOperator

@boring-cyborg boring-cyborg Bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Oct 7, 2023
@boring-cyborg

boring-cyborg Bot commented Oct 7, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@hussein-awala

Copy link
Copy Markdown
Member

The failed tests look unrelated to this change, let me check.

@hussein-awala

Copy link
Copy Markdown
Member

I close an reopen it to execute all the tests

@cached_property
def hook(self) -> KubernetesHook:
hook = KubernetesHook(conn_id=self.kubernetes_conn_id)
hook = KubernetesHook(conn_id=self.kubernetes_conn_id, config_file=self.config_file)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont you think we should have a None check before using the config_file here? If not passed, it will go as None to the hook.

Also can you add some test coverage for this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the existing tests for the modified operators in the last commit

@eladkal
eladkal requested a review from amoghrajesh October 11, 2023 13:29
@eladkal

eladkal commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

tests are failing
@chapm250 can you look into it?

@amoghrajesh amoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chapm250 changes look good, you need to rebase and find out why tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants