Fix Google Provider Link Deprecations#33642
Closed
potiuk wants to merge 1 commit into
Closed
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
Member
Author
|
cc: @bkossakowska -> found it during implementing #33640, once we merge #33640 we should have built-in protection agains similar mistakes. |
potiuk
commented
Aug 23, 2023
This was referenced Aug 23, 2023
potiuk
force-pushed
the
fix-google-provider-deprecations
branch
2 times, most recently
from
45f1708 to
9c602db
Compare
Member
Author
|
cc: @VladaZakharova @bkossakowska -> The tests are failing after removing the deprecated links and I am not sure if my change is correct or not. Can you please comment ? |
eladkal
approved these changes
Aug 23, 2023
potiuk
force-pushed
the
fix-google-provider-deprecations
branch
from
9c602db to
155e9ee
Compare
The Dataproc Links have been deprecated, but they were deprecated wrongly - the Deprecation Warnings were always raised when the dataproc module has been deprecated, but only few classes there were deprecated. This was because the warnings were added as class-level warnings rather than as warnings in constructors. Also the deprecated classes have still been used in operators, raising the warnings even if the deprecation warnings have been moved from class to it's constructor. This PR fixes that: * moves deprecation warnings from classes to constructors * replaces usage of deprecated links with those links that replaced the deprecated ones Found during implementing of apache#33640
potiuk
force-pushed
the
fix-google-provider-deprecations
branch
from
155e9ee to
acf2921
Compare
Member
Author
|
I will close that one - I am mostly guessing what needs to be done. Instead I will make a temporary exclusion for the DataprocLink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dataproc Links have been deprecated, but they were deprecated wrongly - the Deprecation Warnings were always raised when the dataproc module has been deprecated, but only few classes there were deprecated. This was because the warnings were added as class-level warnings rather than as warnings in constructors.
Also the deprecated classes have still been used in operators, raising the warnings even if the deprecation warnings have been moved from class to it's constructor.
This PR fixes that:
Found during implementing of #33640
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.