feat(providers/azure): allow passing fully_qualified_namespace and credential to initialize Azure Service Bus Client#33493
Merged
potiuk merged 3 commits intoAug 26, 2023
Conversation
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
Lee-W
changed the title
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureServiceBus
branch
from
2cd3c18 to
2be0b18
Compare
Member
Author
|
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureServiceBus
branch
from
2be0b18 to
4fe2d9d
Compare
Member
|
Looks good, but we need tests for it. |
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureServiceBus
branch
from
3a6e2e5 to
38b5d44
Compare
…edential to initalize Azure Service Bus Client
as the docstring https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_client.py#L56-L59 mentioned, it can accept the credential from azure-identity
…oks fallback to DefaultAzureCredential when | connection_string is not provided
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureServiceBus
branch
from
38b5d44 to
ca93305
Compare
Member
Author
Sure! Just added tests |
potiuk
approved these changes
Aug 26, 2023
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fully_qualified_namespace,credentialto Azure Service Bus connectionDefaultAzureCredentialsupport for Azure Service Bus Hooks^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.