Fix outdated test name and description in BatchSensor#33407
Merged
vincbeck merged 2 commits intoAug 15, 2023
Merged
Conversation
…or as there's no BatchAsyncSensor
…ure instead of setup_method
boring-cyborg
Bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Aug 15, 2023
vincbeck
left a comment
vincbeck
left a comment
Contributor
There was a problem hiding this comment.
Nice! Thanks for the cleanup!
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During worked on #33405, I noticed that we have
BatchSensorAsynctest cases while this sensor doesn't exist.This PR contains the following changes.
TestBatchSensorAsyncintoTestBatchSensor^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.