Skip to content

Hotfix for #33344, force enable of trigger UI also if no params defined #33353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jscheffl wants to merge 1 commit into from
Closed

Hotfix for #33344, force enable of trigger UI also if no params defined #33353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions airflow/www/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2030,7 +2030,8 @@ def trigger(self, dag_id: str, session: Session = NEW_SESSION):
form_fields[k]["schema"]["custom_html_form"] = Markup(
form_fields[k]["schema"]["custom_html_form"]
)
ui_fields_defined = any("const" not in f["schema"] for f in form_fields.values())
# Hotfix for #33344 - needs further discussion how to handle this post 2.7.0
# ui_fields_defined = any("const" not in f["schema"] for f in form_fields.values())

if not dag_orm:
flash(f"Cannot find dag {dag_id}")
Expand All @@ -2057,7 +2058,7 @@ def trigger(self, dag_id: str, session: Session = NEW_SESSION):
if isinstance(run_conf, dict) and any(run_conf)
}

if request.method == "GET" and ui_fields_defined:
if request.method == "GET": # Hotfix: Force always display form: `and ui_fields_defined:`
# Populate conf textarea with conf requests parameter, or dag.params
default_conf = ""

Expand Down Expand Up @@ -2170,7 +2171,7 @@ def trigger(self, dag_id: str, session: Session = NEW_SESSION):
)

if dag.get_is_paused():
if unpause or not ui_fields_defined:
if unpause: # Hotfix: unpause if no form field: `or not ui_fields_defined:``
flash(f"Unpaused DAG {dag_id}.")
dag_model = models.DagModel.get_dagmodel(dag_id)
if dag_model is not None:
Expand Down