Skip to content

Fix link_names parameter not being passed to hook in SlackWebhookOperator #32919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kojiromike wants to merge 1 commit into from
Closed

Fix link_names parameter not being passed to hook in SlackWebhookOperator #32919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow/providers/slack/operators/slack_webhook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,6 @@ def execute(self, context: Context) -> None:
username=self.username,
icon_emoji=self.icon_emoji,
icon_url=self.icon_url,
# Unused Parameters, if not None than warn user
link_names=self.link_names,
# Unused Parameters, warn user if not None
**({"link_names": self.link_names} if self.link_names else {}),
Comment on lines +172 to +173

@hussein-awala hussein-awala Jul 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a unit test to ensure that the argument is not provided when it's False?

Comment on lines +172 to +173

@Taragolis Taragolis Aug 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Unused Parameters, warn user if not None
**({"link_names": self.link_names} if self.link_names else {}),

AFAIK I mark this value as not used for about I year, so we could just remove provide it in to the hook.

)