Skip to content

Fix try_number shown in the task?task_id=&dag_id=&execution_date= #32361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Jul 5, 2023
Merged

Fix try_number shown in the task?task_id=&dag_id=&execution_date= #32361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2555ee3
try_number fix
Adaverse Jul 5, 2023
9a651ca
change test name
Adaverse Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airflow/www/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1801,7 +1801,8 @@ def task(self, session: Session = NEW_SESSION):
with warnings.catch_warnings():
warnings.simplefilter("ignore", RemovedInAirflow3Warning)
all_ti_attrs = (
(name, getattr(ti, name))
# fetching the value of _try_number to be shown under name try_number in UI
(name, getattr(ti, "_try_number" if name == "try_number" else name))
for name in dir(ti)
if not name.startswith("_") and name not in ti_attrs_to_skip
)
Expand Down
9 changes: 9 additions & 0 deletions tests/www/views/test_views_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,15 @@ def test_views_get(admin_client, url, contents):
check_content_in_response(content, resp)


def test_rendered_task_view(admin_client):
url = f"task?task_id=runme_0&dag_id=example_bash_operator&execution_date={DEFAULT_VAL}"
resp = admin_client.get(url, follow_redirects=True)
resp_html = resp.data.decode("utf-8")
assert resp.status_code == 200
assert "<td>_try_number</td>" not in resp_html
assert "<td>try_number</td>" in resp_html


def test_rendered_k8s(admin_client):
url = f"rendered-k8s?task_id=runme_0&dag_id=example_bash_operator&execution_date={DEFAULT_VAL}"
with unittest.mock.patch.object(settings, "IS_K8S_OR_K8SCELERY_EXECUTOR", True):
Expand Down