Support providing creds lifetime for GCP connection token#31651
Closed
hussein-awala wants to merge 2 commits into
Closed
Support providing creds lifetime for GCP connection token#31651hussein-awala wants to merge 2 commits into
hussein-awala wants to merge 2 commits into
Conversation
boring-cyborg
Bot
added
area:providers
kind:documentation
provider:google
Closed
2 tasks
hussein-awala
requested review from
jedcunningham,
mik-laj and
potiuk
and removed request for
jedcunningham
June 1, 2023 10:46
| if self.lifetime: | ||
| # Create new impersonated credentials with an extended expiration time | ||
| credentials = impersonated_credentials.Credentials( | ||
| source_credentials=credentials.source_credentials, |
There was a problem hiding this comment.
Regarding this comment on issue : #31648 (comment)
I think it's because there are two different Credentials here
It looks like credentials could be one of them according to self.target_principal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #31648
Add a new field for GCP connection extra to override the token default lifetime.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.