Skip to content

Add missing waitForMigrations for workers#31625

Merged
hussein-awala merged 6 commits into
apache:mainfrom
grjones:add-missing-waitformigrations-for-workers
Jun 1, 2023
Merged

Add missing waitForMigrations for workers#31625
hussein-awala merged 6 commits into
apache:mainfrom
grjones:add-missing-waitformigrations-for-workers

Conversation

@grjones

@grjones grjones commented May 30, 2023

Copy link
Copy Markdown
Contributor

Add missing waitForMigrations.enabled flag and associated logic for workers section in helm chart. All other components have this flag.

closes: #31624

@boring-cyborg boring-cyborg Bot added the area:helm-chart Airflow Helm Chart label May 30, 2023
@boring-cyborg

boring-cyborg Bot commented May 30, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jedcunningham

Copy link
Copy Markdown
Member

Good find. Can you add a test like this in here?

@grjones

grjones commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Good find. Can you add a test like this in here?

Sure thing. Added. Let me know if there is anything else I can do.

Comment thread tests/charts/airflow_core/test_worker.py Outdated
Comment thread tests/charts/airflow_core/test_worker.py Outdated
@hussein-awala hussein-awala added the use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) label Jun 1, 2023
@hussein-awala hussein-awala reopened this Jun 1, 2023
@hussein-awala hussein-awala merged commit b1d1227 into apache:main Jun 1, 2023
@boring-cyborg

boring-cyborg Bot commented Jun 1, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@grjones grjones deleted the add-missing-waitformigrations-for-workers branch June 1, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

waitForMigrations.enabled is missing for "workers" helm

3 participants