Skip to content

Testing connection - clearing old alert box when testing connection#31606

Merged
bbovenzi merged 1 commit into
apache:mainfrom
utkarsharma2:testConnFix
May 30, 2023
Merged

Testing connection - clearing old alert box when testing connection#31606
bbovenzi merged 1 commit into
apache:mainfrom
utkarsharma2:testConnFix

Conversation

@utkarsharma2

Copy link
Copy Markdown
Contributor

When testing the connection for the second time the alert box with the old value is confusing, it can mean two things

  1. If the error is still the same
  2. The connection call is not returned yet

Better to clear it before making a testing call.

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 30, 2023

@pankajkoti pankajkoti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it confuses me too, I often go to the browser console to check the response of the newer requests with modified payloads 😄.
Not much expertise with JS here, but if hiding the alert box is the right solution, I like the idea and the fix! Thank you for this! 👏🏽

@utkarsharma2

Copy link
Copy Markdown
Contributor Author

@pankajkoti This was the easiest solution. Ideally, there should be a loader/spinner next to the test button, but that in comparison is more work.

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I agree. We should probably also add a loading indicator to the test connection button. But that can be another PR.

@bbovenzi bbovenzi added this to the Airflow 2.6.2 milestone May 30, 2023
@bbovenzi bbovenzi merged commit efe8473 into apache:main May 30, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants