Remove found_descendents param from get_flat_relative_ids#31559
Conversation
By the looks of it, this param is unused. Since the class is designated private, it is permissable to remove it.
| def get_flat_relative_ids( | ||
| self, | ||
| upstream: bool = False, | ||
| found_descendants: set[str] | None = None, |
There was a problem hiding this comment.
removed this param here
| if found_descendants is None: | ||
| found_descendants = set() |
There was a problem hiding this comment.
thus no longer need this conditional
@uranusjr but then what does |
Yes. I think :meta private: works as designed. https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html Adding the page was one of the reasons to make such decisions quiickly
That technicall means it's not part of the public interface and we are free to change it. |
eladkal
added
the
type:misc/internal
By the looks of it, this param is unused. Since the class is designated private, it is permissable to remove it. (cherry picked from commit 0cbc0dc)
By the looks of it, this param is unused. Since the class is designated private, it is permissable to remove it. (cherry picked from commit 0cbc0dc)
jedcunningham
added
the
changelog:skip
6 participants
By the looks of it, this param is unused. Since the class is designated private, it is permissable to remove it.