Fix sorting of tags#31553
Merged
pierrejeambrun merged 4 commits intoMay 26, 2023
Merged
Conversation
arjunanan6
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
Bot
added
area:UI
Contributor
Author
|
@ashb @pierrejeambrun Sorry about the mess, but could you check this again? |
ashb
approved these changes
May 25, 2023
bbovenzi
approved these changes
May 25, 2023
Contributor
> {% for tag in tags.sort() %}
E TypeError: '<' not supported between instances of 'dict' and 'dict'I guess tags are sometimes a list of dicts, not strings? |
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Indeed tags can be a dict, example in the homepage here
uranusjr
approved these changes
May 26, 2023
pierrejeambrun
approved these changes
May 26, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Fix sorting of tags * Change sorting in views.py * Add ordering into query (cherry picked from commit 24e52f9)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Fix sorting of tags * Change sorting in views.py * Add ordering into query (cherry picked from commit 24e52f9)
62 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #31547
Added a sort to the tags that are to be displayed.