Remove dependency already registered for this task warning#31502
Merged
ephraimbuddy merged 1 commit intoMay 24, 2023
Conversation
The frequent warning about dependency being already registered for a dag
is not needed since task.downstream_task_ids is a set and task.upstream_task_ids is also a set.
The warning usually occurs if your tasks are set up similar to this:
```
task1 = mytask()
for i in range(5):
task2 = anothertask()
task1 >> task2
```
in which case it warns 5 times about task1 dependency is already set.
This PR removes the warning
ephraimbuddy
force-pushed
the
remove-dependency-added-warning
branch
2 times, most recently
from
b7c14b1 to
ed2f5d8
Compare
potiuk
approved these changes
May 24, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit abcfc6f)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit abcfc6f)
62 tasks
2 tasks
jrybicki-jsc
added a commit
to eflows4hpc/dls-dags
that referenced
this pull request
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frequent warning about dependency being already registered for a dag is not needed since task.downstream_task_ids is a set and task.upstream_task_ids is also a set. The warning usually occurs if your tasks are set up similar to this:
in which case it warns 5 times about task1 dependency is already set.
This PR removes the warning