Remove vendored-in google ads library#31368
Merged
Merged
Conversation
potiuk
requested review from
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham and
pierrejeambrun
Now, when we switched to new dependencies for google provider, we can remove the google-ads vendored-in library that has been added to overcome the conflicts between google dependencies. This removes code added in apache#30399
potiuk
force-pushed
the
remove-vendored-in-ads-lib
branch
from
193b894 to
8e74dd6
Compare
Member
Author
|
cc: @ahidalgob |
josh-fell
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, when we switched to new dependencies for google provider, we can remove the google-ads vendored-in library that has been added to overcome the conflicts between google dependencies.
This removes code added in #30399
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.