Skip to content

Added metavar and choices to --state flag in airflow dags list-jobs CLI for suggesting valid state arguments.#31308

Merged
hussein-awala merged 21 commits into
apache:mainfrom
rohan472000:rohan-fix
May 18, 2023
Merged

Added metavar and choices to --state flag in airflow dags list-jobs CLI for suggesting valid state arguments.#31308
hussein-awala merged 21 commits into
apache:mainfrom
rohan472000:rohan-fix

Conversation

@rohan472000

@rohan472000 rohan472000 commented May 16, 2023

Copy link
Copy Markdown
Contributor

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@rohan472000 rohan472000 requested a review from potiuk as a code owner May 16, 2023 05:47
@rohan472000 rohan472000 changed the title Rohan fix Added metavar and choices to --state flag in airflow dags list-jobs CLI for suggesting valid state arguments. May 16, 2023
Comment thread docs/apache-airflow/administration-and-deployment/security/audit-logs.rst Outdated
Comment thread airflow/cli/cli_config.py

@hussein-awala hussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread airflow/cli/cli_config.py
Comment thread airflow/cli/cli_config.py
Comment thread airflow/cli/cli_parser.py
@hussein-awala

Copy link
Copy Markdown
Member

@rohan472000 there's no need to merge the main branch each time. By doing so, the CI will never be completed to merge this PR

@hussein-awala hussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread airflow/cli/cli_config.py Outdated
rohan472000 and others added 2 commits May 18, 2023 13:13
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@hussein-awala hussein-awala merged commit 8e296a0 into apache:main May 18, 2023
@eladkal eladkal added this to the Airflow 2.6.2 milestone Jun 8, 2023
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 8, 2023
…LI for suggesting valid state arguments. (#31308)

(cherry picked from commit 8e296a0)
eladkal pushed a commit that referenced this pull request Jun 9, 2023
…LI for suggesting valid state arguments. (#31308)

(cherry picked from commit 8e296a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI kind:documentation type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants