Make connection id validation consistent across interface#31282
Merged
Conversation
recently, we added the connection id validation if the user creates a connection from UI but this improvement is missing in CLI and API. This PR make sure that connection id validation is consistent across interfaces like CLI, API, and UI.
uranusjr
reviewed
May 15, 2023
uranusjr
approved these changes
May 18, 2023
potiuk
approved these changes
May 18, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Make connection id validation consistent across interface recently, we added the connection id validation if the user creates a connection from UI but this improvement is missing in CLI and API. This PR make sure that connection id validation is consistent across interfaces like CLI, API, and UI. (cherry picked from commit 7bf5339)
eladkal
added
type:misc/internal
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Make connection id validation consistent across interface recently, we added the connection id validation if the user creates a connection from UI but this improvement is missing in CLI and API. This PR make sure that connection id validation is consistent across interfaces like CLI, API, and UI. (cherry picked from commit 7bf5339)
62 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recently, we added the connection id validation
if the user creates a connection from UI but
this improvement is missing in CLI and API.
This PR make sure that connection id validation is consistent
across interfaces like CLI, API, and UI.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.