Upgrade FAB to 4.3.1

[VVildVVolf]

Flask-ApplicationBuilder v4.3.0 has a bug with usage Select2 control. It is fixed in v4.3.1. The description is mentioned in issue #31156

please make sure that you review the classes and models in
# airflow/www/fab_security with their upstream counterparts. In particular, make sure any breaking changes

v4.3.0 vs v4.3.1 looks pretty minor, but includes the change we need. flask_appbuilder/security was not touched.

---

[potiuk]

Did you check if there are no changes in security classes folowing this comment?

    # We are tightly coupled with FAB version because we vendored in part of FAB code related to security manager
    # This is done as part of preparation to removing FAB as dependency, but we are not ready for it yet
    # Every time we update FAB version here, please make sure that you review the classes and models in
    # `airflow/www/fab_security` with their upstream counterparts. In particular, make sure any breaking changes,

[potiuk]

You can see example changes that needed to be ported in past PRs that were upgrading FAB BTW.

[VVildVVolf]

@potiuk ,

You can see example changes that needed to be ported in past PRs that were upgrading FAB BTW.

Yes, I am already using https://github.com/apache/airflow/pull/29766/files as a reference, thanks!

Did you check if there are no changes in security classes folowing this comment?

Mostly I was focused on checking if upgrade of FAB does help or not with the issue #31156 . Good news that upgrading to 4.3.1 helps (but hard to be covered by Unit test, investigating if it is possible). The review of airflow/www/fab_security is in progress - I need to find out some details.

P.S. Just for history maybe it will help someone: to update FAB locally helped:

• some manipulations with docker's ARGs like AIRFLOW_SOURCES_FROM
• breeze ci-image build --upgrade-to-newer-dependencies

[potiuk]

Mostly I was focused on checking if upgrade of FAB does help or not with the issue #31156 . Good news that upgrading to 4.3.1 helps (but hard to be covered by Unit test, investigating if it is possible). The review of airflow/www/fab_security is in progress - I need to find out some details.

From what I understand (I have not done it originally) the security manager was ported "partially" (that is what makes it difficult) - some parts of security manager is completely not used by us (and we did not port it), but some other (authentication types) are - and only changes to those should be ported.

[VVildVVolf]

It looks like the difference v4.3.0 vs v4.3.1 looks pretty minor, but includes the change we need. flask_appbuilder/security was not touched.

[potiuk]

Thanks!